[KinoSearch] Subclassable Highlighter

[Marvin Humphrey]

On Jan 30, 2008, at 1:54 PM, Father Chrysostomos wrote:

>>  * Modify test files...
>
> This patch makes the changes to Highlighter.pm’s public interface,  
> and modifies the test accordingly. It does not yet use  
> HighlightSpan and HeatMap, but it’s enough to get tests passing again.

This is a very nicely put together patch.   I have a couple thoughts,  
but I've applied it verbatim as r2974.

Thanks for the good work.

> Instead of single_excerpt, I’ve named it create_excerpt, in  
> imitation of Hits’s former public method. Also, the ‘single’ is  
> redundant if there’s only one method that creates excerpts.

Perfect.

Marvin Humphrey
Rectangular Research
http://www.rectangular.com/



_______________________________________________
KinoSearch mailing list
KinoSearch at rectangular.com
http://www.rectangular.com/mailman/listinfo/kinosearch