[KinoSearch] Subclassable Highlighter

Marvin Humphrey marvin at rectangular.com
Wed Jan 30 11:25:25 PST 2008




On Jan 30, 2008, at 10:56 AM, Father Chrysostomos wrote:

> On Jan 29, 2008, at 11:03 PM, Marvin Humphrey wrote:
>
>>  * Eliminate anything having to do with highlighting.
>>  * Use $doc->set_doc_num($doc_num).
>>  * Use $doc->set_score instead of putting the score in a faux-field.
>
> The attached patch modifies Hits.pm.

Thanks!  I've applied it as r2972.

> Since it doesn’t touch Highlighter, 303-highlighter.t fails, at  
> least for now.

A couple other tests fail, too.

Failed Test         Stat Wstat Total Fail  List of Failed
------------------------------------------------------------------------ 
-------
t/303-highlighter.t  255 65280     9   18  1-9
t/502-phrasequery.t    1   256     9    1  3
t/508-hits.t           1   256    10    1  2

> <Hits.pm>

A diff file would actually be a little easier for me to deal with, as  
copying Hits.pm over the existing one stomped the variable name  
changes I had just made the previous commit.  :)

Marvin Humphrey
Rectangular Research
http://www.rectangular.com/



_______________________________________________
KinoSearch mailing list
KinoSearch at rectangular.com
http://www.rectangular.com/mailman/listinfo/kinosearch




More information about the kinosearch mailing list