[KinoSearch] Re: Subclassable Highlighter

Father Chrysostomos sprout at cpan.org
Fri Feb 29 16:48:11 PST 2008


On Feb 29, 2008, at 2:14 PM, Marvin Humphrey wrote:

> I'm trying to keep the KS architecture limited to a least-common- 
> denominator single-inheritance OO model; closures don't really fit  
> into that

In that case, here’s a patch that eliminates Encoder:



Also, I noticed there are no tests for pre_tag and post_tag, so here’s  
one.



Also, HTML::Entities is not listed as a prerequisite, but it is  
implied by HTML::Parser. But is HTML::Parser actually used?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://rectangular.com/pipermail/kinosearch/attachments/20080229/92e7810b/attachment-0011.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: goodbye-encoder.diff
Type: application/octet-stream
Size: 5261 bytes
Desc: not available
Url : http://rectangular.com/pipermail/kinosearch/attachments/20080229/92e7810b/attachment-0004.obj 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://rectangular.com/pipermail/kinosearch/attachments/20080229/92e7810b/attachment-0012.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pre_tag-tests.diff
Type: application/octet-stream
Size: 698 bytes
Desc: not available
Url : http://rectangular.com/pipermail/kinosearch/attachments/20080229/92e7810b/attachment-0005.obj 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://rectangular.com/pipermail/kinosearch/attachments/20080229/92e7810b/attachment-0013.htm 
-------------- next part --------------
_______________________________________________
KinoSearch mailing list
KinoSearch at rectangular.com
http://www.rectangular.com/mailman/listinfo/kinosearch


More information about the kinosearch mailing list