[KinoSearch] Subclassable Highlighter

Father Chrysostomos sprout at cpan.org
Tue Feb 5 17:56:29 PST 2008


On Feb 2, 2008, at 1:25 PM, I wrote:

>
> On Feb 1, 2008, at 4:47 PM, Marvin Humphrey wrote:
>
>> Compiling a Query to a Weight, though, is a little expensive to be  
>> doing each for each document.  I think the better solution is to  
>> have the Highlighter compile the Query to a Weight once and cache  
>> it as a member var, then have the cached Weight do the work.
>
> The attached patch does just this. It also removes the encoder and  
> formatter from Highlighter’s constructor, making them accessor  
> methods instead. And I also changed the default window in HeatMap,  
> to match what Highlighter gives it by default (I tried to calculate  
> it too quickly in my head before, and got it wrong :).
>

Here is another patch. It adds more accessor methods to Highlighter,  
which, while writing a subclass, I’ve found I need.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ks-highlight4.diff
Type: application/octet-stream
Size: 771 bytes
Desc: not available
Url : http://www.rectangular.com/pipermail/kinosearch/attachments/20080205/b53e8942/ks-highlight4.obj
-------------- next part --------------



BTW, did you get the last two patches I sent? Should I resend them?



More information about the kinosearch mailing list