[KinoSearch] Possible Phrase Query Bug

[Matthew O'Connor]

On Sep 8, 2007, at 11:28 AM, Nathan Kurz wrote:

> On 9/7/07, Matthew O'Connor <matthew.oconnor at socialtext.com> wrote:
>> I think I've found a bug with phrase queries.
>
> Attached is a patch against SVN that should solve this.  The problem
> was an unsigned integer underflow if the first occurrence of a term
> was at a position less than its phrase offset.

Thanks Nathan!

FYI, your patch did not apply cleanly against SVN trunk.  However,  
since the patch was small it was obvious how to apply it by hand.   
Once I did so all the tests passed.

I then backported the change (via cargo culting) to KS 0.15 (using  
tag 'release-0.15' as a reference).  The tests pass there too and my  
demonstration script no longer exhibits the problem.  I have attached  
this patch against 0.15.

Would it be possible to get another release of the KinoSearch 0.15- 
line with this patch included?  The current trunk seems wildly  
different and  I'd be nervous about upgrading to it right away.

-matthew

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 001-phrase-query-underflow.patch
Type: application/octet-stream
Size: 1858 bytes
Desc: not available
Url : http://rectangular.com/pipermail/kinosearch/attachments/20070908/6f49b1f8/attachment-0001.obj 
-------------- next part --------------
_______________________________________________
KinoSearch mailing list
KinoSearch at rectangular.com
http://www.rectangular.com/mailman/listinfo/kinosearch