[KinoSearch] Possible Phrase Query Bug

[Nathan Kurz]

On 9/9/07, Marvin Humphrey <marvin at rectangular.com> wrote:
> What I actually committed was slightly different, and attempts to
> explain the algorithm more effectively:

I looked at your implementation more closely, and had a few concerns
that I couldn't figure out the answers for.

1) What happens when phrase_offsets[0] is greater than the first
occurrence of the anchor_set?  It seems like there is going to be
another underflow problem, although it doesn't seem to cause problems
when I test for it.

2) I think we continue going through the outer loop even if we have
run out of anchors.  Again, this doesn't seem to cause problems, but
seems suboptimal.

I went ahead and wrote what I think is a more efficient implementation
of the anchor searching.  It may not be a good patch to apply, but
it's the closest thing I've had to an incremental improvement in a
while, so I thought I should send it along. I'll attach it to future
message after a little more cleanup.

Nathan Kurz
nate at verse.com

_______________________________________________
KinoSearch mailing list
KinoSearch at rectangular.com
http://www.rectangular.com/mailman/listinfo/kinosearch