[KinoSearch] remove Hits->seek() [patch]

[Marvin Humphrey]

On Jul 13, 2007, at 2:09 AM, Nathan Kurz wrote:

> Is this the direction you were anticipating?

Yep!

Thanks, applied as repository revision 2490.

> Despite being a tiny patch, there are numerous things that could have
> been done differently, so feel free to point towards the way you would
> prefer.

Anything I might have done differently is superficial.

The important bit is that search-time control flow is now less  
convoluted, which should make the code base both easier to spelunk  
and easier to develop.  Thank you for having the insight to find this  
simplification.

> It seems to pass the test suite, but I haven't done any live testing
> beyond the sample dir.

No other testing is necessary.  There weren't any calls to Hits->seek  
outside of lib/ and t/.  I'll add a changelog entry later for the users.

> Patch is 'svn diff lib t' from within the
> kinosearch/perl directory.  I can clean it up and change it as you
> desire after your feedback.

My only feedback is that this is a well-constructed patch which  
demonstrates your familiarity with the material and upholds the  
necessary internal conventions.  Nicely done.

Marvin Humphrey
Rectangular Research
http://www.rectangular.com/